feat(examples): Implement p/demo/dequeue & p/demo/ratelimiter #2170
Conversation
linhpn99
requested review from
ajnavarro and
deelawn
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
|
@moul i have just implemented queue structure, please take a look ! |
| // PushFront adds an element to the front of the queue. | ||
| // Returns an error if the queue is full. | ||
| func (q *Queue) PushFront(value interface{}) error { | ||
| if q.begin-1 == q.end { |
There was a problem hiding this comment.
With q.begin (uint) set to 0 by default, you may encounter an issue here.
There was a problem hiding this comment.
I have tested this case, q.begin will equal max.Uint64 and does not cause any other runtime errors
|
You are adding general-purpose libraries, which is good. However, it's challenging to review without a real usage example. Could you create dapps using your new libraries or provide more actionable examples? |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
linhpn99
changed the title
linhpn99
changed the title
|
This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months. |
|
I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process. The following requirements must be fulfilled before a pull request can be merged. These requirements are defined in this configuration file. Automated Checks🟢 Maintainers must be able to edit this pull request Manual Checks
Debug
|
From issue : #2119
Using
Dequeuein therate_limiterpackage optimizes action history management by enabling efficient additions and removals at both ends of the queue. This approach ensures constant-time operations and better performance for rate-limiting mechanismsContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description